Fix building on modern nixpkgs/for python3.13#47
Open
mazunki wants to merge 3 commits intoincludeos:masterfrom
Open
Fix building on modern nixpkgs/for python3.13#47mazunki wants to merge 3 commits intoincludeos:masterfrom
mazunki wants to merge 3 commits intoincludeos:masterfrom
Conversation
mazunki
changed the title
Contributor
Author
|
having a space after the shebang is not valid under POSIX
we are using python3, these imports are no longer necessary. in order to remove the `future` library, we might as well remove these dependencies (even if it works with them)
the future python library doesn't exist in current nixpkgs version for python3.13. removing this allows us to compile without overriding nixpkgs version
mazunki
force-pushed
the
fix-build-py3.13
branch
from
e8c309d to
28839e6
Compare
Contributor
Author
|
I'm trying to find a reference for the lack of spaces between shebang and interpreter path. Best I can find is this: Either way, pretty much every recommendation you see around does /not/ use a space. Deviating from the convention makes it harder to grep for these things. Seems like it's actually unspecified, but works on basically all implementations: https://www.in-ulm.de/~mascheck/various/shebang/#blankrequired |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nix-builddoesn't work becausefuturedoesn't exist for python3.13 in current nixpkgs.This PR allows us to compile. It also cleans up some python2.7 legacy, and fixes shebangs.